#PREF SETTER INCOGNITO CODE#

No, you cannot call the implementation of extension APIs from other implementations of the extension API. ( ext-tabs-base.js is probably not the ideal location for this logic, but that's a concern for another bug)įor search and erase, can we directly use contextualIdentities.get() which takes a cookieStoreId and skip obtaining userContextId?

Search on Searchfox for other examples where it is used. This getUserContextIdForCookieStoreId utility (available as a global function in the ext-downloads.js file because this ext-tabs-base.js file is executed in the same scope) can be used to enforce some common checks: We should get both these attributes from the container specified by cookieStoreId, if that's passed. The 2 attributes that we're using from context in download, search, erase are: privateBrowsingAllowed and principal.cookieStoreId uniquely identifies a container.This 'context' holds information about where the (extension) script is executing.

#PREF SETTER INCOGNITO CODE#

'context' in 'user context' is indeed a container, and management of those is exposed through the contextualIdentities extension API.Ĭontext that you see in the code is an instance of a subclass of BaseContext ( list of subclasses).

context = container = ContextualIdentity.

So I was reading up on the docs, and here is what I've gathered. Internally, you should be looking for the userContextId name. To make it easier to find the code that you need to change, search for incognito and isPrivate.Īnother part of the implementation is in the DownloadCore. The implementation of the downloads API is at. To map it to an internal userContextId, use getContainerForCookieStoreId.

- cookieStoreId can be used without additional permission requirements.

The getUserContextIdForCookieStoreId helper can be used for that: (might have to move this method to ext-toolkit.js)

- cookieStoreId requires 'cookies' permission and must not conflict with the incognito preference, among others.

We should support cookieStoreId in the, and APIs, with the following semantics: To get started, read the relevant extension documentation on MDN and see. Below are some hints towards fixing this bug. This bug is especially relevant for the Outreachy project because the ability to resolve this bug is a good predictor for the ability to succeed in the Outreachy project. I want to mark this as a good-second-bug, but since that option doesn't exist I'll mark it as good-first-bug instead.

Pref setter incognito